Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/bitbucket fork pr #84

Merged

Conversation

utkarsh-lambdatest
Copy link
Contributor

Issue Link

Bitbucket, No support for forked repo PRs

Description

In bitbucket we need forked repo slug to fetch the commit info.

Note: In case of private forked repo the user must have read access to the repo if he expects preMerge jobs

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ran bitbucket forked repo pull request jobs on nucleus and synapse
  • Ran gihub forked repo pull request jobs on nucleus and synapse
  • Ran self bitbucket repo pull request jobs on nucleus and synapse
  • Ran self gihub repo pull request jobs on nucleus and synapse
  • Ran bitbucket and github push jobs on nucleus and synapse

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

saurabh-prakash
saurabh-prakash approved these changes Mar 25, 2022
Copy link
Contributor

@VikrantKS VikrantKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@utkarsh-lambdatest utkarsh-lambdatest merged commit 237fdf7 into LambdaTest:dev Mar 25, 2022
saurabh-prakash added a commit that referenced this pull request Mar 28, 2022
* Init git while cloning (#67)

* Init git while cloning

* fixed tests

* Fixed logging

* synapse ws reconnect (#42)

* added retry websocket connection logic

* added connection abort functionality if duplicate connection requested

* added entry in go.mod and go.sum , change restart policy in docker-compose

* fix logout when graceful shutdown

* refactor code and resolve review comments

* change gracefultimeout for synapse from ms to s

* update json keys for test suite payload (#70)

* update json keys for test suite payload

* fixed unit test cases

* added refresh token api (#69)

* added refresh token api

* added unit tests

* added unit test for secret parser expired function

* disable golangci for false positive case

* added comments

* Update README.md (#58) (#76)

Co-authored-by: Saurabh Prakash <saurabhp@lambdatest.com>

* updated readme for ambiguity (#77)

updated readme for ambiguity

* Update main.yml (#79)

* Feature/synapse bitbucket (#80)

* added refresh token api

* added unit tests

* added unit test for secret parser expired function

* disable golangci for false positive case

* added comments

* added token type

* added gitprovider condition in refresh oauth

* added basic auth supprt in git init

* fixed spelling

* fixed unit tests

* fixed unit test

* Changes get oauth secret test

* Bugfix/bitbucket fork pr (#84)

* added refresh token api

* added unit tests

* added unit test for secret parser expired function

* disable golangci for false positive case

* added comments

* added token type

* added gitprovider condition in refresh oauth

* added basic auth supprt in git init

* fixed spelling

* fixed unit tests

* fixed unit test

* Changes get oauth secret test

* updated readme for ambiguity (#77)

updated readme for ambiguity

* Update main.yml (#79)

* added bitbucket forked pr support

Co-authored-by: Nevil Macwan <93511721+nevilm-lt@users.noreply.github.com>
Co-authored-by: Saurabh Prakash <saurabhp@lambdatest.com>

* Removed parsing pod (#52)

* Removed parsing pod

* stable

* updated tests

* Added golangci lint file

* Disabled lint checks for unblocking this change

* Addressed PR comments

Co-authored-by: VikrantKS <96419531+VikrantKS@users.noreply.github.com>
Co-authored-by: palashmarantas <91466368+palashmarantas@users.noreply.github.com>
Co-authored-by: utkarsh-lambdatest <98745310+utkarsh-lambdatest@users.noreply.github.com>
Co-authored-by: Nevil Macwan <93511721+nevilm-lt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants